From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704AbbGPJhN (ORCPT ); Thu, 16 Jul 2015 05:37:13 -0400 Received: from tex.lwn.net ([70.33.254.29]:44017 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753929AbbGPJhL (ORCPT ); Thu, 16 Jul 2015 05:37:11 -0400 Date: Thu, 16 Jul 2015 03:37:04 -0600 From: Jonathan Corbet To: Wang Long Cc: , , , , , Subject: Re: [PATCH] Documentation: Update filesystems/debugfs.txt Message-ID: <20150716033704.7a4e1a5b@lwn.net> In-Reply-To: <1437028276-107088-1-git-send-email-long.wanglong@huawei.com> References: <1437028276-107088-1-git-send-email-long.wanglong@huawei.com> Organization: LWN.net X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2015 06:31:16 +0000 Wang Long wrote: > This patch update the Documentation/filesystems/debugfs.txt > file. The main work is to add the description of the following > functions: > debugfs_create_atomic_t > debugfs_create_u32_array > debugfs_create_devm_seqfile > debugfs_create_file_size I'll apply this because it's a definite improvement over what is there now, but it would be nice to describe these functions a bit more in detail. In particular, a name like debugfs_create_devm_seqfile() will cause at least some developers to think it will clean itself up when the device goes away, but that does not appear to actually be the case... > Copyright 2009 Jonathan Corbet > +Updated by Wang Long on 2015/07/16 I think I'll drop that line, though; that's what the source code management system is for. Arguably the line it follows doesn't really need to be there either... Thanks, jon