From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755887AbbGPQNr (ORCPT ); Thu, 16 Jul 2015 12:13:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55228 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbbGPQNp (ORCPT ); Thu, 16 Jul 2015 12:13:45 -0400 Date: Thu, 16 Jul 2015 18:13:42 +0200 From: Michal Kubecek To: Marcelo Ricardo Leitner Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" Subject: Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support Message-ID: <20150716161342.GA17960@unicorn.suse.cz> References: <20150714122311.8DA8EA0C9A@unicorn.suse.cz> <20150716135059.GB14704@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150716135059.GB14704@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2015 at 10:50:59AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: > > @@ -278,6 +292,14 @@ static int sctp_new_state(enum ip_conntrack_dir dir, > > pr_debug("SCTP_CID_SHUTDOWN_COMPLETE\n"); > > i = 8; > > break; > > + case SCTP_CID_HEARTBEAT: > > + pr_debug("SCTP_CID_HEARTBEAT"); > > + i = 9; > > + break; > > + case SCTP_CID_HEARTBEAT_ACK: > > + pr_debug("SCTP_CID_HEARTBEAT_ACK"); > > + i = 10; > > + break; > > default: > > /* Other chunks like DATA, SACK, HEARTBEAT and > > its ACK do not cause a change in state */ > > Would you update this comment on default case please? As with this > patch, HB and its ACK may cause a change in state. Thank you for catching this. I'll update the comment in v2 I'm going to send tomorrow after some testing. Michal Kubecek