mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: rostedt@goodmis.org, daniel.wagner@bmw-carit.de,
	masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org,
	josh@joshtriplett.org, andi@firstfloor.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map
Date: Thu, 16 Jul 2015 19:49:46 +0200	[thread overview]
Message-ID: <20150716174946.GH12596@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <777bd36975a1dd904fd6b72c4048474dd2327a65.1437066836.git.tom.zanussi@linux.intel.com>

On Thu, Jul 16, 2015 at 12:22:40PM -0500, Tom Zanussi wrote:
> +	for (i = 0; i < elt->map->n_fields; i++) {
> +		atomic64_set(&dup_elt->fields[i].sum,
> +			     atomic64_read(&elt->fields[i].sum));
> +		dup_elt->fields[i].cmp_fn = elt->fields[i].cmp_fn;
> +	}
> +
> +	return dup_elt;
> +}

So there is a lot of atomic64_{set,read}() in this patch set, what kind
of magic properties do you assume they have?

Note that atomic*_{set,read}() are weaker than {WRITE,READ}_ONCE(), so
if you're assuming they do that, you're mistaken -- although it is on a
TODO list someplace to go fix that.

  reply	other threads:[~2015-07-16 17:50 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 17:22 [PATCH v9 00/22] tracing: 'hist' triggers Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 01/22] tracing: Update cond flag when enabling or disabling a trigger Tom Zanussi
2015-07-21 10:04   ` Masami Hiramatsu
2015-07-16 17:22 ` [PATCH v9 02/22] tracing: Make ftrace_event_field checking functions available Tom Zanussi
2015-07-21 10:04   ` Masami Hiramatsu
2015-07-21 14:26     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 03/22] tracing: Make event trigger " Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 04/22] tracing: Add event record param to trigger_ops.func() Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 05/22] tracing: Add get_syscall_name() Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 06/22] tracing: Add a per-event-trigger 'paused' field Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 07/22] tracing: Add lock-free tracing_map Tom Zanussi
2015-07-16 17:49   ` Peter Zijlstra [this message]
2015-07-16 21:41     ` Tom Zanussi
2015-07-16 22:32       ` Peter Zijlstra
2015-07-17  1:51         ` Tom Zanussi
2015-07-16 18:03   ` Peter Zijlstra
2015-07-16 21:33     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 08/22] tracing: Add 'hist' event trigger command Tom Zanussi
2015-07-20 13:37   ` Masami Hiramatsu
2015-07-21 14:17     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 09/22] tracing: Add hist trigger support for multiple values ('vals=' param) Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 10/22] tracing: Add hist trigger support for compound keys Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 11/22] tracing: Add hist trigger support for user-defined sorting ('sort=' param) Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 12/22] tracing: Add hist trigger support for pausing and continuing a trace Tom Zanussi
2015-07-22  8:20   ` Masami Hiramatsu
2015-07-22 20:22     ` Tom Zanussi
2015-07-23 14:06       ` Masami Hiramatsu
2015-07-23 15:58         ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 13/22] tracing: Add hist trigger support for clearing " Tom Zanussi
2015-07-22 13:50   ` Masami Hiramatsu
2015-07-22 20:24     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 14/22] tracing: Add hist trigger 'hex' modifier for displaying numeric fields Tom Zanussi
2015-07-19 13:22   ` Namhyung Kim
2015-07-21 14:10     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 15/22] tracing: Add hist trigger 'sym' and 'sym-offset' modifiers Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 16/22] tracing: Add hist trigger 'execname' modifier Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 17/22] tracing: Add hist trigger 'syscall' modifier Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 18/22] tracing: Add hist trigger support for stacktraces as keys Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 19/22] tracing: Support string type key properly Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 20/22] tracing: Remove restriction on string position in hist trigger keys Tom Zanussi
2015-07-19 13:31   ` Namhyung Kim
2015-07-21 14:15     ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 21/22] tracing: Add enable_hist/disable_hist triggers Tom Zanussi
2015-07-20 14:57   ` Masami Hiramatsu
2015-07-21 16:10     ` Tom Zanussi
2015-07-22 14:21       ` Masami Hiramatsu
2015-07-22 20:18         ` Tom Zanussi
2015-07-16 17:22 ` [PATCH v9 22/22] tracing: Add 'hist' trigger Documentation Tom Zanussi
2015-07-21  9:40 ` [PATCH v9 00/22] tracing: 'hist' triggers Masami Hiramatsu
2015-07-21 14:18   ` Tom Zanussi
2015-07-22 18:29 ` Brendan Gregg
2015-07-23  1:55   ` Tom Zanussi
     [not found] <E1ZFsPd-0005o8-JJ@feisty.vs19.net>
2015-07-16 23:25 ` [PATCH v9 07/22] tracing: Add lock-free tracing_map Mathieu Desnoyers
2015-07-17  1:35   ` Tom Zanussi
2015-07-17 15:48     ` Mathieu Desnoyers
2015-07-17 23:44       ` Tom Zanussi
2015-07-18  2:40         ` Mathieu Desnoyers
2015-07-18 12:52           ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716174946.GH12596@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andi@firstfloor.org \
    --cc=daniel.wagner@bmw-carit.de \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome