From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756095AbbGPUR7 (ORCPT ); Thu, 16 Jul 2015 16:17:59 -0400 Received: from casper.infradead.org ([85.118.1.10]:45250 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756029AbbGPUR6 (ORCPT ); Thu, 16 Jul 2015 16:17:58 -0400 Date: Thu, 16 Jul 2015 22:17:49 +0200 From: Peter Zijlstra To: Sukadev Bhattiprolu Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 3/8] perf: Add a flags parameter to pmu txn interfaces Message-ID: <20150716201749.GL3644@twins.programming.kicks-ass.net> References: <1436929315-28520-1-git-send-email-sukadev@linux.vnet.ibm.com> <1436929315-28520-4-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436929315-28520-4-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2015 at 08:01:50PM -0700, Sukadev Bhattiprolu wrote: > @@ -1604,6 +1613,12 @@ static void power_pmu_start_txn(struct pmu *pmu) > static void power_pmu_cancel_txn(struct pmu *pmu) > { > struct cpu_hw_events *cpuhw = this_cpu_ptr(&cpu_hw_events); > + int txn_flags; > + > + txn_flags = cpuhw->txn_flags; > + cpuhw->txn_flags = 0; > + if (cpuhw->txn_flags & ~PERF_PMU_TXN_ADD) > + return; That seems, unintentional? ;-)