From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbbGPQ55 (ORCPT ); Thu, 16 Jul 2015 12:57:57 -0400 Received: from 202-89-161-53.static.dsl.amnet.net.au ([202.89.161.53]:43700 "EHLO GateKeeper.xayto.local" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751033AbbGPQ54 (ORCPT ); Thu, 16 Jul 2015 12:57:56 -0400 Date: Fri, 17 Jul 2015 00:57:19 +0000 From: Craig Inches To: Craig Inches Cc: Joe Perches , Craig Inches , lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: drivers: dgnc Message-ID: <20150717005719.GA17691@Morat.xayto.local> References: <1437088293-12128-1-git-send-email-craig.inches@xayto.net> <1437060653.16262.25.camel@perches.com> <20150717002041.GA8792@Morat.xayto.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717002041.GA8792@Morat.xayto.local> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 12:20:42AM +0000, Craig Inches wrote: > Hi Joe, > > On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote: > > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote: > > > Fixed up some checkpatch.pl style issues. > > > Line greater than 80 Chars in multiple locations. > > > > I think most all of these are not improvements. > Ok, can you be a little more specific? I did see some that where > not worth modifying due to only being 1 or 2 chars over, and > breaking the line seemed pointless. > > > Please use --strict when verifying your patches. > Not sure where the --strict should be set? I cant see the option > in the checklist.pl script found it missed the line after --subjective with -h I shall take another crack at a patch, I see some issues introduced which wern't reported with just a normal checkpatch.pl run. > > Please fix the time on your systemp. > Thanks for pointing that out, my mail servers time was out. > > Thanks for your feedback. > Craig -- Craig Inches