Re: [PATCH v4] staging: rtl8192u: remove bool comparisons

[Luis de Bethencourt <luis@debethencourt.com>]

On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote:
> On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparisons to bool variables.
> > 
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> <snip>
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index b852396..41cf99d 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -2043,16 +2043,10 @@ static bool GetNmodeSupportBySecCfg8192(struct net_device *dev)
> >  
> >  static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
> >  {
> > -	bool			Reval;
> >  	struct r8192_priv *priv = ieee80211_priv(dev);
> >  	struct ieee80211_device *ieee = priv->ieee80211;
> >  
> > -	if (ieee->bHalfWirelessN24GMode == true)
> > -		Reval = true;
> > -	else
> > -		Reval =  false;
> > -
> > -	return Reval;
> > +	return ieee->bHalfWirelessN24GMode;
> I think this should have been in a separate patch.
> 
> regards
> sudip

That's a good point. It is related but a different fix than removing booolean
comparisons.

Thanks once again for review Sudip :)

Going to send a new version soon,
Luis