From: Jean Delvare <jdelvare@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Odzioba, Lukasz" <lukasz.odzioba@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data
Date: Fri, 17 Jul 2015 23:25:07 +0200 [thread overview]
Message-ID: <20150717232507.1839182e@endymion.delvare> (raw)
In-Reply-To: <55A95942.4060605@roeck-us.net>
On Fri, 17 Jul 2015 12:36:34 -0700, Guenter Roeck wrote:
> Hi Jean,
>
> On 07/17/2015 12:11 PM, Jean Delvare wrote:
>
> >
> > We could just drop NUM_REAL_CORES and use CONFIG_NR_CPUS instead, I
> > would be fine with that. This lets people worried about memory
> > consumption control it.
>
> Unfortunately this won't work because the CPU ID is non-linear;
> an 8-core system may have a CPU ID larger than 7.
Oh right, I forgot about that. Brilliant hardware/firmware engineers...
Well that does not prevent us from using CONFIG_NR_CPUS, "just" the
code would need to be modified to remove the assumption that the array
index matches the logical CPU ID.
BTW I wonder how the rest of the kernel handles the situation.
CONFIG_NR_CPUS is used where relevant so there certainly _is_ a linear
numbering which is independent from the CPU ID.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-07-17 21:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:04 Lukasz Odzioba
2015-07-15 21:07 ` Jean Delvare
2015-07-16 13:17 ` Odzioba, Lukasz
2015-07-17 16:55 ` Guenter Roeck
2015-07-17 17:28 ` Odzioba, Lukasz
2015-07-17 18:01 ` Guenter Roeck
2015-07-17 19:23 ` Odzioba, Lukasz
2015-07-17 21:33 ` Jean Delvare
2015-07-17 19:11 ` Jean Delvare
2015-07-17 19:36 ` Guenter Roeck
2015-07-17 21:25 ` Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-01 21:25 [PATCH] hwmon: coretemp: fix oops on cpu unplug Guenter Roeck
2012-05-02 15:10 ` [PATCH] hwmon: coretemp: use list instead of fixed size array for temp data Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717232507.1839182e@endymion.delvare \
--to=jdelvare@suse.de \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=lukasz.odzioba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®