From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752664AbbGRJQm (ORCPT <rfc822;w@1wt.eu>);
	Sat, 18 Jul 2015 05:16:42 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56805 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751080AbbGRJQk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 18 Jul 2015 05:16:40 -0400
Date: Sat, 18 Jul 2015 10:16:08 +0100
From: Mark Brown <broonie@kernel.org>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de,
        sonnyrao@chromium.org, linux-rockchip@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Message-ID: <20150718091608.GW11162@sirena.org.uk>
References: <1437196124-32655-1-git-send-email-zhengxing@rock-chips.com>
 <1437196124-32655-2-git-send-email-zhengxing@rock-chips.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="SU+pDiHQETgHpG/P"
Content-Disposition: inline
In-Reply-To: <1437196124-32655-2-git-send-email-zhengxing@rock-chips.com>
X-Cookie: Stay together, drag each other down.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v2 1/2] ASoC: rockchip: Add machine driver for max98090
 codec
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--SU+pDiHQETgHpG/P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jul 18, 2015 at 01:08:43PM +0800, Xing Zheng wrote:

> +	ret = devm_snd_soc_register_card(&pdev->dev, card);
> +	if (ret) {
> +		dev_err(&pdev->dev,
> +			"Soc register card failed %d\n", ret);
> +		return ret;
> +	}
> +
> +	return ret;
> +}
> +
> +static int snd_rk_mc_remove(struct platform_device *pdev)
> +{
> +	struct snd_soc_card *soc_card = platform_get_drvdata(pdev);
> +
> +	snd_soc_unregister_card(soc_card);

The point with using devm_snd_soc_register_card() is that you don't need
to manually unregister the card - devm_ ensures that the card is freed.

--SU+pDiHQETgHpG/P
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVqhlYAAoJECTWi3JdVIfQeeMH/RQhtnroV3QJcbWmfaUlQuZA
fOTUiJm45e43jgZsUScveDom6QrjpS+P5O8XQqtAcG7UuVUNY0LOmDB3TzWATH8O
VwAgpNBiCO3d2AW6cQMj2vdTSRc7xueCj6XGtbTJVZLpXJGaJ25h+ftmWc85R6de
BuYi1k5/F3Hu8PjdPjAWceZkYAIGGgzrJsFN6DRHdVfcyrlDAC4eT22bi8jqlK3R
bFsPwsvG1dQq8A0QbClwoeRtV0Tt2kweRE2ZZpQoneIjYyYjCZCunvmRqe3P8KPs
EJo73jIXWwxo15x94iVWwJ2qg0dSeA/9LqZqCDR7j35BZjb29vIQElTIe3xb7lE=
=Pay8
-----END PGP SIGNATURE-----

--SU+pDiHQETgHpG/P--