From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbbGSWDg (ORCPT ); Sun, 19 Jul 2015 18:03:36 -0400 Received: from down.free-electrons.com ([37.187.137.238]:35982 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754040AbbGSWDf (ORCPT ); Sun, 19 Jul 2015 18:03:35 -0400 Date: Mon, 20 Jul 2015 00:03:33 +0200 From: Alexandre Belloni To: rnd4@dave-tech.it Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Andrea Scian Subject: Re: [rtc-linux] [PATCH v2] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user Message-ID: <20150719220333.GB15539@piout.net> References: <557EF5DD.9070300@dave-tech.it> <1434447587-23992-1-git-send-email-rnd4@dave-tech.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434447587-23992-1-git-send-email-rnd4@dave-tech.it> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2015 at 11:39:47 +0200, rnd4@dave-tech.it wrote : > From: Andrea Scian > > Signed-off-by: Andrea Scian > --- > > Changes since v1: > * use BIT() to select the right bitfield instead of hardcode value > * return -EINVAL if OFS is detected > * cache OSF into driver structure to warn the user even later > > drivers/rtc/rtc-pcf2127.c | 26 +++++++++++++++++++++++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > Applied, after adding back the commit message. Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com