From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbbGUDiJ (ORCPT ); Mon, 20 Jul 2015 23:38:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54486 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbbGUDiH (ORCPT ); Mon, 20 Jul 2015 23:38:07 -0400 Date: Mon, 20 Jul 2015 20:38:06 -0700 (PDT) Message-Id: <20150720.203806.2301067437587964745.davem@davemloft.net> To: m-karicheri2@ti.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, w-kwok2@ti.com Subject: Re: [PATCH] net: netcp: fix improper initialization in netcp_ndo_open() From: David Miller In-Reply-To: <1437075134-24423-1-git-send-email-m-karicheri2@ti.com> References: <1437075134-24423-1-git-send-email-m-karicheri2@ti.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2015 20:38:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murali Karicheri Date: Thu, 16 Jul 2015 15:32:14 -0400 > The keystone qmss will raise interrupt when packet arrive at the > receive queue. Only control available to avoid interrupt from happening > is to keep the free descriptor queue (FDQ) empty in the receive side. > So the filling of descriptors into the FDQ has to happen after > request_irq() call is made as part of knav_queue_enable_notify(). So > move the function netcp_rxpool_refill() after this call. > > Signed-off-by: Murali Karicheri Applied, thanks.