From: Minfei Huang <mnfhuang@gmail.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
akpm@linux-foundation.org, tony.luck@intel.com,
wangnan0@huawei.com, david.vrabel@citrix.com, yinghai@kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Assign the initail value to the pmd_idx
Date: Mon, 20 Jul 2015 15:26:29 +0800 [thread overview]
Message-ID: <20150720072629.GA46717@huangminfeis-MacBook-Pro.local> (raw)
In-Reply-To: <1436703522-29552-1-git-send-email-mhuang@redhat.com>
ping.
Can someone help review this patch?
Thanks
Minfei
On 07/12/15 at 08:18P, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
>
> The variable pmd_idx is undefined, when we try to start the loop to
> calculate the page.
>
> Assign the proper value which indexes the start address to make it work
> well.
>
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
> arch/x86/mm/init_32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index 8340e45..68aec42 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -137,6 +137,7 @@ page_table_range_init_count(unsigned long start, unsigned long end)
>
> vaddr = start;
> pgd_idx = pgd_index(vaddr);
> + pmd_idx = pmd_index(vaddr);
>
> for ( ; (pgd_idx < PTRS_PER_PGD) && (vaddr != end); pgd_idx++) {
> for (; (pmd_idx < PTRS_PER_PMD) && (vaddr != end);
> --
> 2.2.2
>
next prev parent reply other threads:[~2015-07-20 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 12:18 Minfei Huang
2015-07-20 7:26 ` Minfei Huang [this message]
2015-07-20 18:28 ` Yinghai Lu
2015-07-20 21:18 ` [tip:x86/mm] x86/mm: Initialize pmd_idx in page_table_range_init_count() tip-bot for Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720072629.GA46717@huangminfeis-MacBook-Pro.local \
--to=mnfhuang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhuang@redhat.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wangnan0@huawei.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®