From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbbGTStz (ORCPT ); Mon, 20 Jul 2015 14:49:55 -0400 Received: from casper.infradead.org ([85.118.1.10]:37149 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbbGTStv (ORCPT ); Mon, 20 Jul 2015 14:49:51 -0400 Date: Mon, 20 Jul 2015 20:49:45 +0200 From: Peter Zijlstra To: Andy Lutomirski Cc: Steven Rostedt , "security@kernel.org" , X86 ML , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] x86/nmi: Remove the b2b parameter from nmi_handle Message-ID: <20150720184945.GH19282@twins.programming.kicks-ass.net> References: <52f21be0c90995bf9b8ee4d0d9073e07ed197018.1437417770.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52f21be0c90995bf9b8ee4d0d9073e07ed197018.1437417770.git.luto@kernel.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 20, 2015 at 11:47:11AM -0700, Andy Lutomirski wrote: > @@ -300,6 +300,7 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs) > panic("NMI: Not continuing"); > > pr_emerg("Dazed and confused, but trying to continue\n"); > + dump_stack(); > } > NOKPROBE_SYMBOL(unknown_nmi_error); > I think you got a lost hunk there..