From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbbGUBOw (ORCPT ); Mon, 20 Jul 2015 21:14:52 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:14534 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932321AbbGUBOv (ORCPT ); Mon, 20 Jul 2015 21:14:51 -0400 Date: Mon, 20 Jul 2015 21:15:29 -0400 From: Steven Rostedt To: Joe Perches Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Andy Whitcroft Subject: Re: [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods Message-ID: <20150720211529.2c0a311d@grimm.local.home> In-Reply-To: <1437440779.28284.7.camel@perches.com> References: <20150717221949.GA12304@linux.vnet.ibm.com> <1437171616-13832-1-git-send-email-paulmck@linux.vnet.ibm.com> <1437171616-13832-15-git-send-email-paulmck@linux.vnet.ibm.com> <1437172674.2495.60.camel@perches.com> <20150720205547.150c7a05@grimm.local.home> <1437440779.28284.7.camel@perches.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2015 18:06:19 -0700 Joe Perches wrote: > On Mon, 2015-07-20 at 20:55 -0400, Steven Rostedt wrote: > > On Fri, 17 Jul 2015 15:37:54 -0700 > > Joe Perches wrote: > > > > > > + if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) { > > > > > > It'd be faster perl without capture groups: > > > > Is checkpatch such a critical code path that we could possibly notice > > the difference in speed? Although the above may be few microseconds > > slower, to me, the above looks a hell of a lot more readable. > > Regardless, it's not as capable as it wouldn't find > any miswritten form like > > synchronize__expedited ( args... ) Then that's a better rational than performance. -- Steve