From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756678AbbGTVkf (ORCPT ); Mon, 20 Jul 2015 17:40:35 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43151 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbbGTVkd (ORCPT ); Mon, 20 Jul 2015 17:40:33 -0400 Date: Mon, 20 Jul 2015 14:40:32 -0700 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] toshiba_acpi: Transflective backlight updates Message-ID: <20150720214032.GB34611@vmdeb7> References: <1437089632-4293-1-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437089632-4293-1-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2015 at 05:33:52PM -0600, Azael Avalos wrote: > This patch changes the tr function seconf parameter from bool to u32, second > to be in par with the rest of the TCI functions of the driver, and the on par > code was updated accordingly. > > Also, the check for translective support was moved to the *add > function, as the {__get, set}_lcd_brightness functions amke use of it. make I can make minor typographical corrections, but please do be more careful :) > > Signed-off-by: Azael Avalos Otherwise, looks good. No need to resend. -- Darren Hart Intel Open Source Technology Center