mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kristen Carlson Accardi <kristen@linux.intel.com>
To: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Cc: <rjw@rjwysocki.net>, <viresh.kumar@linaro.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<yishimat@redhat.com>,
	Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@intel.com>
Subject: Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing
Date: Tue, 21 Jul 2015 13:11:47 -0700	[thread overview]
Message-ID: <20150721131147.75f772bc@kcaccard-desk.amr.corp.intel.com> (raw)
In-Reply-To: <1437468073-9668-1-git-send-email-lukasz.anaczkowski@intel.com>

On Tue, 21 Jul 2015 10:41:13 +0200
Lukasz Anaczkowski <lukasz.anaczkowski@intel.com> wrote:

> Scaling for Knights Landing is same as the default scaling (100000).
> When Knigts Landing support was added to the pstate driver, this
> parameter was omitted resulting in a kernel panic during boot.
> 
> Reported-by: Yasuaki Ishimatsu <yishimat@redhat.com>
> Signed-off-by: Dasaratharaman Chandramouli <dasaratharaman.chandramouli@intel.com>
> Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 15ada47..fcb929e 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -681,6 +681,7 @@ static struct cpu_defaults knl_params = {
>  		.get_max = core_get_max_pstate,
>  		.get_min = core_get_min_pstate,
>  		.get_turbo = knl_get_turbo_pstate,
> +		.get_scaling = core_get_scaling,
>  		.set = core_set_pstate,
>  	},
>  };

Acked-by: Kristen Carlson Accardi <kristen@linux.intel.com>

  reply	other threads:[~2015-07-21 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  8:41 Lukasz Anaczkowski
2015-07-21 20:11 ` Kristen Carlson Accardi [this message]
2015-07-23 21:01 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721131147.75f772bc@kcaccard-desk.amr.corp.intel.com \
    --to=kristen@linux.intel.com \
    --cc=dasaratharaman.chandramouli@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.anaczkowski@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    --cc=yishimat@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®