mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "Liang, Kan" <kan.liang@intel.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC V5 2/4] perf,tool: per-event time support
Date: Tue, 21 Jul 2015 16:56:15 +0200	[thread overview]
Message-ID: <20150721145615.GB21171@krava.brq.redhat.com> (raw)
In-Reply-To: <20150721144501.GA10689@danjae.kornet>

On Tue, Jul 21, 2015 at 11:45:01PM +0900, Namhyung Kim wrote:

SNIP

> > > 
> > > [jolsa@krava perf]$ ./perf record -e 'cpu/instructions,period=20000/' -c
> > > 1000 sleep 1 [ perf record: Woken up 1 times to write data ] /proc/kcore
> > > requires CAP_SYS_RAWIO capability to access.
> > > [ perf record: Captured and wrote 0.015 MB perf.data (35 samples) ]
> > > [jolsa@krava perf]$ ./perf evlist -vv
> > > cpu/instructions,period=20000/: type: 4, size: 112, config: 0xc0,
> > > { sample_period, sample_freq }: 20000
> > > 
> > 
> > So you are going to change current behavior?
> > The current behavior is "global opts setting" > "per_event settring" > default
> > You are going to change it to "per_event settring" > "global opts setting" >
> > Default. Right?
> 
> Hmm.. I agree that changing current behavior is not good.  But I think
> it makes more sense to prefer per-event settings over global settings
> in general.

hum right.. but it's just period ATM that will be affected..
I'd risk it, since I dont think maybe people actualy used it ;-)

together with time term, which wasn't possible to change before
anyway, so there should be no problem

jirka

  reply	other threads:[~2015-07-21 14:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 11:30 [PATCH RFC V5 0/4] per event callgrap and " kan.liang
2015-07-17 11:30 ` [PATCH RFC V5 1/4] perf,tools: introduce callgraph_set for callgraph option kan.liang
2015-07-17 11:30 ` [PATCH RFC V5 2/4] perf,tool: per-event time support kan.liang
2015-07-18 12:45   ` Jiri Olsa
2015-07-19  3:21     ` Namhyung Kim
2015-07-19 19:13       ` Jiri Olsa
2015-07-20 15:04         ` Liang, Kan
2015-07-20 17:40           ` Jiri Olsa
2015-07-21  3:39             ` Liang, Kan
2015-07-21 14:45               ` Namhyung Kim
2015-07-21 14:56                 ` Jiri Olsa [this message]
2015-07-21 14:59               ` Jiri Olsa
2015-07-17 11:30 ` [PATCH RFC V5 3/4] perf,tool: per-event callgrap support kan.liang
2015-07-17 11:30 ` [PATCH RFC V5 4/4] perf,tests: Add tests to callgrap and time parse kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721145615.GB21171@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®