From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Donald Parsons <dparsons@brightdsl.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.0 00/58] 4.0.9-stable review
Date: Tue, 21 Jul 2015 11:13:58 -0700 [thread overview]
Message-ID: <20150721181358.GA20131@kroah.com> (raw)
In-Reply-To: <1437498807.5718.15.camel@falcon.homelinux.org>
On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> Greg,
>
> The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon
> Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14)
>
> This mis-compile was fixed in 4.1-rc8. The diff was:
>
> diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> linux-4.1-rc8/arch/x86/kvm/mmu.c
> --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400
> +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400
> @@ -4215,13 +4215,13 @@
> u64 entry, gentry, *spte;
> int npte;
> bool remote_flush, local_flush, zap_page;
> - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> - .cr0_wp = 1,
> - .cr4_pae = 1,
> - .nxe = 1,
> - .smep_andnot_wp = 1,
> - .smap_andnot_wp = 1,
> - };
> + union kvm_mmu_page_role mask = { };
> +
> + mask.cr0_wp = 1;
> + mask.cr4_pae = 1;
> + mask.nxe = 1;
> + mask.smep_andnot_wp = 1;
> + mask.smap_andnot_wp = 1;
>
> /*
> * If we don't have indirect shadow pages, it means no page is
>
>
> Please add to linux-4.0.9 so older compilers will work.
What is the commit id in Linus's tree that resolves this?
thanks,
greg k-h
next prev parent reply other threads:[~2015-07-21 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 17:13 Donald Parsons
2015-07-21 18:13 ` Greg Kroah-Hartman [this message]
2015-07-21 21:02 ` Donald Parsons
2015-07-21 21:10 ` Greg Kroah-Hartman
2015-07-21 22:14 ` Donald Parsons
2015-07-22 3:20 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-07-19 19:10 Greg Kroah-Hartman
2015-07-20 3:17 ` Guenter Roeck
2015-07-20 7:18 ` Sudip Mukherjee
2015-07-20 17:18 ` Shuah Khan
2015-07-20 21:29 ` Rafael J. Wysocki
2015-07-20 22:04 ` Greg Kroah-Hartman
2015-07-20 22:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721181358.GA20131@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dparsons@brightdsl.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome