From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932850AbbGVIEs (ORCPT ); Wed, 22 Jul 2015 04:04:48 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33544 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756006AbbGVIEo (ORCPT ); Wed, 22 Jul 2015 04:04:44 -0400 Date: Wed, 22 Jul 2015 10:04:36 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Denys Vlasenko , Linus Torvalds , Jan Kara , Ingo Molnar Subject: Re: [PATCH resend] x86: Fix detection of GCC -mpreferred-stack-boundary support Message-ID: <20150722080436.GE7979@nazgul.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2015 at 09:27:18AM -0700, Andy Lutomirski wrote: > +# prevent gcc from generating any FP code by mistake > +# This must be before we try -mpreferred-stack-boundary -- see > +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383 > +KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow > +KBUILD_CFLAGS += $(call cc-option,-mno-avx,) Should we unify all FPU-generating switches to one place? I've added this # Don't autogenerate traditional x87 instructions KBUILD_CFLAGS += $(call cc-option,-mno-80387) KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387) to the 64-bit build a while back but I don't see why it shouldn't be in the generic part of the Makefile... Also, 32-bit has -msoft-float which, according to the gcc manpage is ignored but I guess should be kept for older gccs... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --