From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753789AbbGWQVn (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jul 2015 12:21:43 -0400
Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:44527 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752577AbbGWQVf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jul 2015 12:21:35 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:5007:6120:6261:7875:10004:10400:10848:10967:11232:11658:11914:12043:12296:12517:12519:12740:13069:13149:13230:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: wood05_47a2aa37e7443
X-Filterd-Recvd-Size: 2004
Date: Thu, 23 Jul 2015 12:21:30 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>, Adrian Hunter <adrian.hunter@intel.com>,
        Borislav Petkov <bp@suse.de>, Frederic Weisbecker <fweisbec@gmail.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative
 symbol resolver
Message-ID: <20150723122130.716df9fe@gandalf.local.home>
In-Reply-To: <20150723150433.GA3154@kernel.org>
References: <20150723150433.GA3154@kernel.org>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 23 Jul 2015 12:04:33 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

>
> +static struct func_map *
> +find_func(struct pevent *pevent, unsigned long long addr)
> +{
> +	static struct func_map map;

I know there's other cases of static variables in functions, but I plan
on cleaning that up in the future.

Can you make that map belong to the pevent itself? In case there's two
pevent's going parallel, I don't want one to overwrite the other. The
pevent code is not re-entrant, but I would like to make it so for
different pevents.

-- Steve


> +
> +	if (!function_resolver.function)
> +		return __find_func(pevent, addr);
> +
> +	map.mod	 = NULL;
> +	map.addr = addr;
> +	map.func = function_resolver.function(function_resolver.priv, &map.addr, &map.mod);
> +	if (map.func == NULL)
> +		return NULL;
> +
> +	return &map;
> +}
> +