From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969AbbGWSLj (ORCPT ); Thu, 23 Jul 2015 14:11:39 -0400 Received: from smtprelay0243.hostedemail.com ([216.40.44.243]:42680 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753393AbbGWSLh (ORCPT ); Thu, 23 Jul 2015 14:11:37 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3872:3874:4321:5007:6120:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: loaf96_dd9f2f251541 X-Filterd-Recvd-Size: 2987 Date: Thu, 23 Jul 2015 14:11:33 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: David Ahern , Adrian Hunter , Borislav Petkov , Frederic Weisbecker , Jiri Olsa , Namhyung Kim , Stephane Eranian , Ingo Molnar , Linux Kernel Mailing List Subject: Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver Message-ID: <20150723141133.4065321e@gandalf.local.home> In-Reply-To: <20150723141039.1bd48bf2@gandalf.local.home> References: <20150723150433.GA3154@kernel.org> <20150723122130.716df9fe@gandalf.local.home> <20150723172554.GC3154@kernel.org> <20150723141039.1bd48bf2@gandalf.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt wrote: > On Thu, 23 Jul 2015 14:25:54 -0300 > Arnaldo Carvalho de Melo wrote: > > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > > index cc25f059ab3d..2750e7e7efff 100644 > > --- a/tools/lib/traceevent/event-parse.c > > +++ b/tools/lib/traceevent/event-parse.c > > @@ -418,7 +418,7 @@ static int func_map_init(struct pevent *pevent) > > } > > > > static struct func_map * > > -find_func(struct pevent *pevent, unsigned long long addr) > > +__find_func(struct pevent *pevent, unsigned long long addr) > > { > > struct func_map *func; > > struct func_map key; > > @@ -434,6 +434,51 @@ find_func(struct pevent *pevent, unsigned long long addr) > > return func; > > } > > > > +static struct { > > + pevent_function_resolver_t *function; > > + void *priv; > > +} function_resolver; > > + > > +/** > > + * pevent_set_function_resolver - set an alternative function resolver > > + * @resolver - function to be used > > + * @priv - resolver function private state. > > + * > > + * Some tools may have already a way to resolve kernel functions, allow them > > + * to keep using it instead of duplicating all the entries inside pevent->funclist. > > + */ > > +void pevent_set_function_resolver(pevent_function_resolver_t *resolver, void *priv) > > +{ > > + function_resolver.function = resolver; > > + function_resolver.priv = priv; > > What about passing in pevent, and making the allocation here? In fact, we could remove the global function_resolver, and allocate that here too. -- Steve > > -- Steve > > > +} > > +