mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	devel@driverdev.osuosl.org,
	Tapasweni Pathak <tapaswenipathak@gmail.com>,
	Vaishali Thakkar <vthakkar1994@gmail.com>,
	linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 3/5] staging: rtl8712: remove duplicate struct
Date: Fri, 24 Jul 2015 13:01:02 -0700	[thread overview]
Message-ID: <20150724200102.GA22385@kroah.com> (raw)
In-Reply-To: <1563309.ulsDW4l8M4@diplodocus>

On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote:
> struct ndis_wlan_bssid_ex is a dopelganger of
> struct wlan_bssid_ex, and is used about a third as often
> 
> Switch all instances to wlan_bssid_ex
> 
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> 
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_cmd.c         | 17 ++++++-------
>  drivers/staging/rtl8712/rtl871x_cmd.h         |  4 +--
>  drivers/staging/rtl8712/rtl871x_event.h       |  2 +-
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 10 ++++----
>  drivers/staging/rtl8712/rtl871x_mlme.c        | 35 
> +++++++++++++--------------
>  drivers/staging/rtl8712/rtl871x_mlme.h        |  2 +-
>  drivers/staging/rtl8712/rtl871x_mp_ioctl.c    |  6 ++---
>  drivers/staging/rtl8712/wlan_bssdef.h         | 23 ++----------------
>  8 files changed, 38 insertions(+), 61 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c 
> b/drivers/staging/rtl8712/rtl871x_cmd.c
> index f07050d..ef71829 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> @@ -456,9 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
>  	INIT_LIST_HEAD(&pcmd->list);
>  	pcmd->cmdcode = _CreateBss_CMD_;
>  	pcmd->parmbuf = (unsigned char *)pdev_network;
> -	pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz((
> -			struct ndis_wlan_bssid_ex *)
> -			pdev_network);
> +	pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(pdev_network);
>  	pcmd->rsp = NULL;
>  	pcmd->rspsz = 0;
>  	/* notes: translate IELength & Length after assign to cmdsz; */
> @@ -471,7 +469,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter)
>  
>  u8 r8712_joinbss_cmd(struct _adapter  *padapter, struct wlan_network 
> *pnetwork)

Patch is line-wrapped and can not be applied :(

Can you redo this whole series and resend properly?  Your 0/5 email
needs a subject as well...

thanks,

greg k-h

      parent reply	other threads:[~2015-07-24 20:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  4:57 Joshua Clayton
2015-07-24  8:32 ` Sudip Mukherjee
2015-07-24 12:39   ` Joshua Clayton
2015-07-24 12:56     ` Dan Carpenter
2015-07-24 20:01 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150724200102.GA22385@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stillcompiling@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tapaswenipathak@gmail.com \
    --cc=vthakkar1994@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome