From: Minfei Huang <mhuang@redhat.com>
To: vgoyal@redhat.com, Dave Young <dyoung@redhat.com>
Cc: ebiederm@xmission.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Minfei Huang <mnfhuang@gmail.com>
Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic
Date: Sat, 25 Jul 2015 17:11:31 +0800 [thread overview]
Message-ID: <20150725091131.GA7062@dhcp-128-25.nay.redhat.com> (raw)
In-Reply-To: <20150615092848.GB15858@dhcp-128-59.nay.redhat.com>
Hi, Vivek.
Since Dave acked this patch, Could you help to merge it?
Thanks
Minfei
On 06/15/15 at 05:28pm, Dave Young wrote:
> On 06/06/15 at 02:14pm, Minfei Huang wrote:
> > From: Minfei Huang <mnfhuang@gmail.com>
> >
> > Transforming PFN(Page Frame Number) to struct page is never failure, so
> > we can simplify the code logic to do the image->control_page assignment
> > directly in the loop, and remove the unnecessary conditional judgement.
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> > ---
> > kernel/kexec.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/kernel/kexec.c b/kernel/kexec.c
> > index 7a36fdc..4589899 100644
> > --- a/kernel/kexec.c
> > +++ b/kernel/kexec.c
> > @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
> > /* If I don't overlap any segments I have found my hole! */
> > if (i == image->nr_segments) {
> > pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> > + image->control_page = hole_end;
> > break;
> > }
> > }
> > - if (pages)
> > - image->control_page = hole_end;
> >
> > return pages;
> > }
>
> Acked-by: Dave Young <dyoung@redhat.com>
>
> Thanks
> Dave
next prev parent reply other threads:[~2015-07-25 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 6:14 Minfei Huang
2015-06-15 9:28 ` Dave Young
2015-07-25 9:11 ` Minfei Huang [this message]
2015-07-27 13:44 ` Vivek Goyal
2015-07-28 4:30 ` Simon Horman
2015-07-28 4:42 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150725091131.GA7062@dhcp-128-25.nay.redhat.com \
--to=mhuang@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnfhuang@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®