From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755412AbbGZQgN (ORCPT ); Sun, 26 Jul 2015 12:36:13 -0400 Received: from mail-am1on0146.outbound.protection.outlook.com ([157.56.112.146]:38726 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755221AbbGZQgL convert rfc822-to-8bit (ORCPT ); Sun, 26 Jul 2015 12:36:11 -0400 From: "Joglekar, Tejas (T.)" To: Jes Sorensen CC: "Larry.Finger@lwfinger.net" , "gregkh@linuxfoundation.org" , "linux-wireless@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error Thread-Topic: [PATCH] staging:rtl8723au:core:rtw_sreset.c:Fix for space related error Thread-Index: AQHQx3ZlB3bi3dNqmUiZfGq7eibPjZ3ttyx9gAA8NgA= Date: Sun, 26 Jul 2015 16:36:07 +0000 Message-ID: <20150726163600.GA3341@tejas-asus.domain.name> References: <20150726074009.GA14066@tejas-asus.domain.name> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [49.248.82.222] x-microsoft-exchange-diagnostics: 1;AM2PR06MB0609;24:gx9d0ar6zhsLcKNeUDFQr5Xb2RkVpQOVh1e8o0lXsL8R9ufjt18VHXPLZkTb5MDxEFo+4K3Fygre0kBLhQsB4HY3qoSe3ZocMn7QTa96U5Q=;20:roY5fxJ+S5NhsrL+tipemAVS4Zvepg2UI4QgvKnr9789zc+yv1LrfRrUQkgziy70iXb0P0Fe7bgVlHH6VbMgew== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR06MB0609; am2pr06mb0609: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:AM2PR06MB0609;BCL:0;PCL:0;RULEID:;SRVR:AM2PR06MB0609; x-forefront-prvs: 064903DDDC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(110136002)(62966003)(5001920100001)(77156002)(5001960100002)(102836002)(92566002)(77096005)(189998001)(40100003)(106116001)(122556002)(46102003)(87936001)(5002640100001)(19580405001)(19580395003)(33656002)(86362001)(2656002)(54356999)(50986999)(2900100001)(2950100001)(76176999)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM2PR06MB0609;H:AM2PR06MB0609.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <62C3C069AD302F44A555D68EE231721D@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2015 16:36:07.9706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR06MB0609 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2015 at 09:00:23AM -0400, Jes Sorensen wrote: > "Joglekar, Tejas (T.)" writes: > > From: Joglekar Tejas > > > > This patch fixes the error given by checkpatch.pl > > > > Signed-off-by: Joglekar Tejas > > --- > > drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c > > index 29a29d9..48b7723 100644 > > --- a/drivers/staging/rtl8723au/core/rtw_sreset.c > > +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c > > @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter) > > /* pairwise key */ > > rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true); > > /* group key */ > > - rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0); > > + rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0); > > } > > } > > } > > NAK! > > If you are 'fixing' checkpatch 'errors', do it properly and break down > the line and solve the 80 character limit 'error' as well. > > Jes Jes , Sure, I will break down the line, and remove the 80 character limit issue , before resending the patch. Thanks & Regards, Tejas Joglekar