From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbbG1IjK (ORCPT ); Tue, 28 Jul 2015 04:39:10 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:39459 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754791AbbG1IjI (ORCPT ); Tue, 28 Jul 2015 04:39:08 -0400 Date: Tue, 28 Jul 2015 10:39:05 +0200 From: Ralf Baechle To: Paul Burton Cc: linux-mips@linux-mips.org, Guenter Roeck , Matthew Fortune , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h Message-ID: <20150728083905.GE30938@linux-mips.org> References: <1438027107-24420-1-git-send-email-paul.burton@imgtec.com> <1438027107-24420-2-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438027107-24420-2-git-send-email-paul.burton@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 12:58:12PM -0700, Paul Burton wrote: > The offsets to various fields within struct sigcontext are declared > using asm-offsets.c these days, so drop the outdated comment that talks > about keeping in sync with a no longer present file. The file was renamed not removed and the comment still applies. I've recently fixed the comment so this patch again is against would reject aside of being wrong so I'm dropping it. > diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h > index 6c9906f..ae78902 100644 > --- a/arch/mips/include/uapi/asm/sigcontext.h > +++ b/arch/mips/include/uapi/asm/sigcontext.h > @@ -14,10 +14,6 @@ > > #if _MIPS_SIM == _MIPS_SIM_ABI32 > > -/* > - * Keep this struct definition in sync with the sigcontext fragment > - * in arch/mips/tools/offset.c > - */ > struct sigcontext { > unsigned int sc_regmask; /* Unused */ > unsigned int sc_status; /* Unused */ > @@ -45,9 +41,6 @@ struct sigcontext { > > #include > /* > - * Keep this struct definition in sync with the sigcontext fragment > - * in arch/mips/tools/offset.c > - * Ralf