From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106AbbG1JmA (ORCPT ); Tue, 28 Jul 2015 05:42:00 -0400 Received: from mail.skyhub.de ([78.46.96.112]:38682 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbG1Jl6 (ORCPT ); Tue, 28 Jul 2015 05:41:58 -0400 Date: Tue, 28 Jul 2015 11:41:53 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , linux-kernel@vger.kernel.org, Brian Gerst , Steven Rostedt , Willy Tarreau , Thomas Gleixner , Peter Zijlstra , Linus Torvalds Subject: Re: [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe Message-ID: <20150728094153.GB1612@nazgul.tnic> References: <13a3ceb8d36e5fa77b3b9e7a2006245a72b25f5d.1437803711.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <13a3ceb8d36e5fa77b3b9e7a2006245a72b25f5d.1437803711.git.luto@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 10:57:04PM -0700, Andy Lutomirski wrote: > This will allow IRQ stacks to nest inside NMIs or similar entries > that can happen during IRQ stack setup or teardown. > > The Xen code here has a confusing comment. > > The new macros won't work correctly if they're invoked with IRQs on. > Add a check under CONFIG_DEBUG_ENTRY to detect that. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/Kconfig.debug | 2 - > arch/x86/entry/entry_64.S | 89 +++++++++++++++++++++++++++++--------------- > arch/x86/kernel/process_64.c | 4 ++ > 3 files changed, 63 insertions(+), 32 deletions(-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --