From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>,
linux-kernel@vger.kernel.org, Brian Gerst <brgerst@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>, Willy Tarreau <w@1wt.eu>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v2 2/3] x86/entry/64: Teach idtentry to use the IRQ stack
Date: Tue, 28 Jul 2015 11:50:19 +0200 [thread overview]
Message-ID: <20150728095019.GD1612@nazgul.tnic> (raw)
In-Reply-To: <74421f7102368e3396a652bb7ed49afb65f07e09.1437803711.git.luto@kernel.org>
On Fri, Jul 24, 2015 at 10:57:05PM -0700, Andy Lutomirski wrote:
> We don't specifically need IST for things like kprobes, but we do
> want to avoid rare, surprising extra stack usage if a kprobe hits
> with a deep stack.
>
> Teach idtentry to use the IRQ stack for selected entries.
>
> This implementation uses the IRQ stack even if we entered from user
> mode. This disallows tricks like ist_begin_non_atomic. If we ever
> need such a trick in one of these entries, we can rework this. For
> now, let's keep it simple.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/entry/entry_64.S | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-07-28 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 5:57 [PATCH v2 0/3] x86_64: Make int3 non-magical Andy Lutomirski
2015-07-25 5:57 ` [PATCH v2 1/3] x86/entry/64: Refactor IRQ stacks and make them NMI-safe Andy Lutomirski
2015-07-26 6:05 ` Borislav Petkov
2015-07-26 18:50 ` Andy Lutomirski
2015-07-28 9:41 ` Borislav Petkov
2015-08-17 11:18 ` Andy Shevchenko
2015-08-19 15:50 ` Andy Lutomirski
2015-07-25 5:57 ` [PATCH v2 2/3] x86/entry/64: Teach idtentry to use the IRQ stack Andy Lutomirski
2015-07-28 9:50 ` Borislav Petkov [this message]
2015-07-25 5:57 ` [PATCH v2 3/3] x86/entry/64: Move #BP from IST to " Andy Lutomirski
2015-07-28 9:54 ` Borislav Petkov
2015-07-29 17:57 ` Andy Lutomirski
2015-07-30 4:19 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728095019.GD1612@nazgul.tnic \
--to=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome