From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755577AbbG1OKL (ORCPT ); Tue, 28 Jul 2015 10:10:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbbG1OKJ (ORCPT ); Tue, 28 Jul 2015 10:10:09 -0400 Date: Tue, 28 Jul 2015 16:10:06 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , jolsa@kernel.org Subject: Re: [PATCH] perf, tools, stat: Fix perf stat -T Message-ID: <20150728141006.GE28175@krava.brq.redhat.com> References: <1438039491-22091-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438039491-22091-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > From: Andi Kleen > > The transaction length metrics in perf stat -T broke recently. > It would not match the metric correctly and always print K/sec. > This was caused by a incorrect update of the cycles_in_tx statistics. > Update the correct variable. > > Also the check for zero division was reversed, which resulted > in K/sec being printed for no transactions. Fix this also up. > > Cc: jolsa@kernel.org > Signed-off-by: Andi Kleen > --- > tools/perf/util/stat-shadow.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > index 53e8bb7..2a5d8d7 100644 > --- a/tools/perf/util/stat-shadow.c > +++ b/tools/perf/util/stat-shadow.c > @@ -85,7 +85,7 @@ void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 *count, > else if (perf_evsel__match(counter, HARDWARE, HW_CPU_CYCLES)) > update_stats(&runtime_cycles_stats[ctx][cpu], count[0]); > else if (perf_stat_evsel__is(counter, CYCLES_IN_TX)) > - update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); > + update_stats(&runtime_cycles_in_tx_stats[ctx][cpu], count[0]); oops, looks like copy&paste issue.. thanks > else if (perf_stat_evsel__is(counter, TRANSACTION_START)) > update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); > else if (perf_stat_evsel__is(counter, ELISION_START)) > @@ -398,20 +398,18 @@ void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel, > " # %5.2f%% aborted cycles ", > 100.0 * ((total2-avg) / total)); > } else if (perf_stat_evsel__is(evsel, TRANSACTION_START) && > - avg > 0 && > runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { > total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); > > - if (total) > + if (avg) > ratio = total / avg; > > fprintf(out, " # %8.0f cycles / transaction ", ratio); > } else if (perf_stat_evsel__is(evsel, ELISION_START) && > - avg > 0 && > runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { > total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); > > - if (total) > + if (avg) > ratio = total / avg; > > fprintf(out, " # %8.0f cycles / elision ", ratio); > -- we now print comment line if the avg is 0, but I think it's ok Acked-by: Jiri Olsa thanks, jirka