From: David Miller <davem@davemloft.net>
To: al.drozdov@gmail.com
Cc: dborkman@redhat.com, edumazet@google.com, willemb@google.com,
viro@zeniv.linux.org.uk, eyal.birger@gmail.com, mst@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison
Date: Wed, 29 Jul 2015 00:10:36 -0700 (PDT) [thread overview]
Message-ID: <20150729.001036.271920963041164246.davem@davemloft.net> (raw)
In-Reply-To: <1438081021-1321-1-git-send-email-al.drozdov@gmail.com>
From: Alexander Drozdov <al.drozdov@gmail.com>
Date: Tue, 28 Jul 2015 13:57:01 +0300
> tpacket_fill_skb() can return a negative value (-errno) which
> is stored in tp_len variable. In that case the following
> condition will be (but shouldn't be) true:
>
> tp_len > dev->mtu + dev->hard_header_len
>
> as dev->mtu and dev->hard_header_len are both unsigned.
>
> That may lead to just returning an incorrect EMSGSIZE errno
> to the user.
>
> Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2015-07-29 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 10:57 Alexander Drozdov
2015-07-28 11:07 ` Daniel Borkmann
2015-07-28 11:38 ` Eric Dumazet
2015-07-29 7:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729.001036.271920963041164246.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=al.drozdov@gmail.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®