mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfeldma@gmail.com
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
	jiri@resnulli.us, f.fainelli@gmail.com,
	linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH] net: switchdev: restrict vid range abstraction
Date: Wed, 29 Jul 2015 11:28:42 -0700 (PDT)	[thread overview]
Message-ID: <20150729.112842.1871916445536378243.davem@davemloft.net> (raw)
In-Reply-To: <CAE4R7bA5jh3Rgn_U1Sit3qW+i2vKNE++c9TYTJ8sp5j8h=awbw@mail.gmail.com>

From: Scott Feldman <sfeldma@gmail.com>
Date: Wed, 29 Jul 2015 00:31:44 -0700

> Since the netlink request (for example vlan add) includes the range,
> I'm not seeing how we can response with success for the satisfied
> vlans in the range, and also respond with an error for the unsatisfied
> vlans in the range.   In other words, from the netlink msgs
> perspective, we need to treat a vlan range as all-or-nothing.  So in
> your example, if hw can't add vlan 2, we fail the entire request to
> add range 2-5.  This is where the prepare phase checks to make sure
> the entire request can be satisfied before committing to hw.

This was my concern with the change as well.

The user asked for the range to be installed, so if any portion
of it cannot be done we must not make any changes to the HW
configuration and fail the entire request.

  reply	other threads:[~2015-07-29 18:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26 23:45 Vivien Didelot
2015-07-29  7:31 ` Scott Feldman
2015-07-29 18:28   ` David Miller [this message]
2015-07-29 19:14     ` Vivien Didelot
2015-07-29 19:28       ` David Miller
2015-07-29 21:17       ` Scott Feldman
2015-08-01  1:02         ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729.112842.1871916445536378243.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®