From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbbG3Gze (ORCPT ); Thu, 30 Jul 2015 02:55:34 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36510 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbbG3Gzd (ORCPT ); Thu, 30 Jul 2015 02:55:33 -0400 Date: Wed, 29 Jul 2015 23:55:32 -0700 (PDT) Message-Id: <20150729.235532.2011128033027594424.davem@davemloft.net> To: nathan.sullivan@ni.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/phy: micrel: Reenable interrupts during resume From: David Miller In-Reply-To: <1438183274-4631-1-git-send-email-nathan.sullivan@ni.com> References: <1438183274-4631-1-git-send-email-nathan.sullivan@ni.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jul 2015 23:55:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6U6tele031163 From: Nathan Sullivan Date: Wed, 29 Jul 2015 10:21:14 -0500 > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 499185e..7a93af6 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -447,6 +447,22 @@ static int ksz9031_center_flp_timing(struct phy_device *phydev) > return genphy_restart_aneg(phydev); > } > > +static int ksz9031_resume(struct phy_device *phydev) > +{ > + int result; > + > + result = genphy_resume(phydev); > + > + if (result) > + return result; > + > + /* This phy will reset interrupt enables when leaving power down */ > + if (PHY_INTERRUPT_ENABLED & phydev->interrupts) > + result = kszphy_set_interrupt(phydev); > + This doesn't compile. drivers/net/phy/micrel.c: In function ksz9031_resume: drivers/net/phy/micrel.c:461:3: error: implicit declaration of function kszphy_set_interrupt [-Werror=implicit-function-declaration] result = kszphy_set_interrupt(phydev); ^ cc1: some warnings being treated as errors scripts/Makefile.build:264: recipe for target 'drivers/net/phy/micrel.o' failed {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I