From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbbG2I7E (ORCPT ); Wed, 29 Jul 2015 04:59:04 -0400 Received: from casper.infradead.org ([85.118.1.10]:48418 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbbG2I7A (ORCPT ); Wed, 29 Jul 2015 04:59:00 -0400 Date: Wed, 29 Jul 2015 10:58:53 +0200 From: Peter Zijlstra To: Heiko Carstens Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jasonbaron0@gmail.com, bp@alien8.de, luto@amacapital.net, tglx@linutronix.de, rostedt@goodmis.org, will.deacon@arm.com, liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org, ddaney@caviumnetworks.com, benh@kernel.crashing.org, michael@ellerman.id.au, davem@davemloft.net, vbabka@suse.cz Subject: Re: [PATCH -v2 0/8] jump_label: Another (better) static_key interface Message-ID: <20150729085853.GJ19282@twins.programming.kicks-ass.net> References: <20150728132055.203176565@infradead.org> <20150729064600.GB3953@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150729064600.GB3953@osiris> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2015 at 08:46:00AM +0200, Heiko Carstens wrote: > On Tue, Jul 28, 2015 at 03:20:55PM +0200, Peter Zijlstra wrote: > > Hi all, > > > > After yet another bug because of the weirdness of the static key interface, > > here an attempt at providing a better one. > > > > This series is tested on x86_64 (by me) and s390x (heiko). > > Works nice. You may include the s390 patch below, so the conversion to the > new interface happens when your code gets merged: > > From 3c9b5a2b9a90d6bb2b41f381f5f89b3657fe4ea5 Mon Sep 17 00:00:00 2001 > From: Heiko Carstens > Date: Wed, 29 Jul 2015 08:31:24 +0200 > Subject: [PATCH] s390/uaccess: employ static_branch_likely() > > Use the new static_branch_likely() primitive to make sure that the > most likely case is executed without taking an unconditional branch. > This wasn't possible with the old jump label primitives. > > Signed-off-by: Heiko Carstens Thanks!