From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbbG2HPH (ORCPT ); Wed, 29 Jul 2015 03:15:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:49995 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbbG2HPF (ORCPT ); Wed, 29 Jul 2015 03:15:05 -0400 Date: Wed, 29 Jul 2015 09:14:58 +0200 From: Jean Delvare To: Vladimir Zapolskiy Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] misc: eeprom: clean up eeprom_read() Message-ID: <20150729091458.511ebb6c@endymion.delvare> In-Reply-To: <1437945533-27996-4-git-send-email-vz@mleia.com> References: <1437945502-27944-1-git-send-email-vz@mleia.com> <1437945533-27996-4-git-send-email-vz@mleia.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2015 00:18:49 +0300, Vladimir Zapolskiy wrote: > The change removes redundant sysfs binary file boundary check, since > this task is already done on caller side in fs/sysfs/file.c > > Signed-off-by: Vladimir Zapolskiy > Cc: Jean Delvare > --- > drivers/misc/eeprom/eeprom.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c > index b432873..7342fd6 100644 > --- a/drivers/misc/eeprom/eeprom.c > +++ b/drivers/misc/eeprom/eeprom.c > @@ -88,11 +88,6 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, > struct eeprom_data *data = i2c_get_clientdata(client); > u8 slice; > > - if (off > EEPROM_SIZE) > - return 0; > - if (off + count > EEPROM_SIZE) > - count = EEPROM_SIZE - off; > - > /* Only refresh slices which contain requested bytes */ > for (slice = off >> 5; slice <= (off + count - 1) >> 5; slice++) > eeprom_update_client(client, slice); Thanks for the clean-up. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support