From: Wei Liu <wei.liu2@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: "Wei Liu" <wei.liu2@citrix.com>,
linux-fbdev@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
stefano.stabellini@eu.citrix.com,
"Russell King" <linux@arm.linux.org.uk>,
linux-scsi@vger.kernel.org, x86@kernel.org,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Jiri Slaby" <jslaby@suse.com>,
xen-devel@lists.xenproject.org,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
linux-input@vger.kernel.org, ian.campbell@citrix.com,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Ingo Molnar" <mingo@redhat.com>,
linux-arm-kernel@lists.infradead.org,
"Juergen Gross" <jgross@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
"David Vrabel" <david.vrabel@citrix.com>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies
Date: Wed, 29 Jul 2015 12:39:01 +0100 [thread overview]
Message-ID: <20150729113901.GB7962@zion.uk.xensource.com> (raw)
In-Reply-To: <55B8BA9A.8000502@citrix.com>
On Wed, Jul 29, 2015 at 12:35:54PM +0100, Julien Grall wrote:
> Hi Wei,
>
> On 29/07/15 11:13, Wei Liu wrote:
> > On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote:
> > [...]
> >> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> >> index 7d50711..3b7b7c3 100644
> >> --- a/drivers/net/xen-netback/netback.c
> >> +++ b/drivers/net/xen-netback/netback.c
> >> @@ -314,7 +314,7 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb
> >> } else {
> >> copy_gop->source.domid = DOMID_SELF;
> >> copy_gop->source.u.gmfn =
> >> - virt_to_mfn(page_address(page));
> >> + virt_to_gfn(page_address(page));
> >> }
> >> copy_gop->source.offset = offset;
> >>
> >> @@ -1284,7 +1284,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
> >> queue->tx_copy_ops[*copy_ops].source.offset = txreq.offset;
> >>
> >> queue->tx_copy_ops[*copy_ops].dest.u.gmfn =
> >> - virt_to_mfn(skb->data);
> >> + virt_to_gfn(skb->data);
> >> queue->tx_copy_ops[*copy_ops].dest.domid = DOMID_SELF;
> >> queue->tx_copy_ops[*copy_ops].dest.offset =
> >> offset_in_page(skb->data);
> >
> > Reviewed-by: Wei Liu <wei.liu2@citrix.com>
> >
> > One possible improvement is to change gmfn in copy_gop to gfn as well.
> > But that's outside of netback code.
>
> The structure gnttab_copy is part of the hypervisor interface. Is it
> fine to differ on the naming between Xen and Linux?
>
> Or maybe we could do the change in the public headers in Xen repo too.
> Is it fine to do field renaming in public headers?
>
Oh well. Never mind then. I mistook that structure as internal to Linux.
Wei.
> Regards,
>
> --
> Julien Grall
next prev parent reply other threads:[~2015-07-29 11:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 15:02 [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall
2015-07-28 15:02 ` [PATCH 1/8] arm/xen: Remove helpers which are PV specific Julien Grall
2015-07-31 10:44 ` Stefano Stabellini
2015-07-31 10:55 ` Ian Campbell
2015-08-04 16:36 ` [Xen-devel] " Julien Grall
2015-07-28 15:02 ` [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall
2015-07-28 15:52 ` [Xen-devel] " David Vrabel
2015-07-28 16:06 ` Julien Grall
2015-07-31 10:54 ` Stefano Stabellini
2015-07-28 15:02 ` [PATCH 3/8] arm/xen: implement correctly pfn_to_mfn Julien Grall
2015-07-28 15:02 ` [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall
2015-07-28 17:16 ` [Xen-devel] " David Vrabel
2015-07-29 11:06 ` Julien Grall
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-29 11:25 ` Julien Grall
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-28 19:39 ` [Xen-devel] " Chris (Christopher) Brand
2015-07-29 11:27 ` Julien Grall
2015-07-29 10:13 ` Wei Liu
2015-07-29 11:35 ` [Xen-devel] " Julien Grall
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:39 ` Wei Liu [this message]
2015-07-31 11:02 ` Stefano Stabellini
2015-07-28 15:02 ` [PATCH 5/8] xen/tmem: Use page_to_gfn rather than pfn_to_gfn Julien Grall
2015-07-28 15:02 ` [PATCH 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up Julien Grall
2015-07-28 17:16 ` [Xen-devel] " David Vrabel
2015-07-28 15:02 ` [PATCH 7/8] hvc/xen: " Julien Grall
2015-07-28 17:17 ` [Xen-devel] " David Vrabel
2015-07-28 15:02 ` [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up Julien Grall
2015-07-28 17:19 ` [Xen-devel] " David Vrabel
2015-07-28 21:06 ` [PATCH 0/8] Use correctly the Xen memory terminologies in Linux H. Peter Anvin
2015-07-28 21:12 ` [Xen-devel] " Andrew Cooper
2015-07-29 11:02 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729113901.GB7962@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=JBottomley@odin.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jgross@suse.com \
--cc=jslaby@suse.com \
--cc=julien.grall@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=tomi.valkeinen@ti.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®