mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
	ak@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC V6 5/6] perf,tool: per-event callgraph support
Date: Wed, 29 Jul 2015 13:50:08 +0200	[thread overview]
Message-ID: <20150729115008.GD9606@krava.brq.redhat.com> (raw)
In-Reply-To: <1437999699-19632-6-git-send-email-kan.liang@intel.com>

On Mon, Jul 27, 2015 at 08:21:38AM -0400, Kan Liang wrote:

SNIP

> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 7febfe2..874de7d 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -545,14 +545,15 @@ int perf_evsel__group_desc(struct perf_evsel *evsel, char *buf, size_t size)
>  
>  static void
>  perf_evsel__config_callgraph(struct perf_evsel *evsel,
> -			     struct record_opts *opts)
> +			     struct record_opts *opts,
> +			     struct callchain_param *param)

could you put this change (and related) into separate patch?

thanks,
jirka

  parent reply	other threads:[~2015-07-29 11:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 12:21 [PATCH RFC V6 0/6] per event callgraph and time support Kan Liang
2015-07-27 12:21 ` [PATCH RFC V6 1/6] perf tools: Add support for event post configuration Kan Liang
2015-07-27 12:21 ` [PATCH RFC V6 2/6] perf tools: Force period term to overload global settings Kan Liang
2015-07-27 12:21 ` [PATCH RFC V6 3/6] perf,tools: introduce callgraph_set for callgraph option Kan Liang
2015-07-27 12:21 ` [PATCH RFC V6 4/6] perf,tool: per-event time support Kan Liang
2015-07-29 11:02   ` Jiri Olsa
2015-07-27 12:21 ` [PATCH RFC V6 5/6] perf,tool: per-event callgraph support Kan Liang
2015-07-29 11:20   ` Jiri Olsa
2015-07-29 11:48   ` Jiri Olsa
2015-07-29 11:50   ` Jiri Olsa [this message]
2015-07-27 12:21 ` [PATCH RFC V6 6/6] perf,tests: Add tests to callgraph and time parse Kan Liang
2015-07-29 11:53   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729115008.GD9606@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®