mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: mingo@elte.hu, akpm@linux-foundation.org, bp@suse.de,
	tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org,
	dan.j.williams@intel.com, linux-next@vger.kernel.org,
	arnd@arndb.de, linux-kernel@vger.kernel.org,
	benh@kernel.crashing.org, "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH] arch/*/io.h: Add ioremap_uc() to all architectures
Date: Wed, 29 Jul 2015 13:09:11 +1000	[thread overview]
Message-ID: <20150729130911.21f1dc72@canb.auug.org.au> (raw)
In-Reply-To: <1438107727-12287-1-git-send-email-mcgrof@do-not-panic.com>

Hi Luis,

On Tue, 28 Jul 2015 11:22:07 -0700 "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
>
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This adds ioremap_uc() only for architectures that do not
> include asm-generic.h/io.h as that already provides a default
> definition for them for both cases where you have CONFIG_MMU
> and you do not, and because of this, the number of architectures
> this patch address is less than the architectures that the
> ioremap_wt() patch addressed, "arch/*/io.h: Add ioremap_wt() to all
> architectures").
> 
> In order to reduce the number of architectures we have to
> modify when adding new architecture IO APIs we'll have to review
> the architectures in this patch, see why they can't add
> asm-generic.h/io.h or issues that would be created by doing
> so and then spread a consistent inclusion of this header
> towards the end of their own header. For instance arch/metag
> includes the asm-generic/io.h *before* the ioremap*()
> definitions, this should be the other way around but only
> once we have guard wrappers for the non-MMU case also for
> asm-generic/io.h.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
>  arch/avr32/include/asm/io.h   | 1 +
>  arch/frv/include/asm/io.h     | 1 +
>  arch/m32r/include/asm/io.h    | 1 +
>  arch/m68k/include/asm/io_mm.h | 1 +
>  arch/mn10300/include/asm/io.h | 1 +
>  arch/powerpc/include/asm/io.h | 1 +
>  arch/sh/include/asm/io.h      | 1 +
>  arch/tile/include/asm/io.h    | 1 +
>  8 files changed, 8 insertions(+)

I have added this to linux-next today instead of reverting the other 2
patches.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

      reply	other threads:[~2015-07-29  3:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 18:22 Luis R. Rodriguez
2015-07-29  3:09 ` Stephen Rothwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729130911.21f1dc72@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bp@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    --cc=mcgrof@suse.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®