From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752048AbbG3Wv3 (ORCPT ); Thu, 30 Jul 2015 18:51:29 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41796 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbbG3Wv1 (ORCPT ); Thu, 30 Jul 2015 18:51:27 -0400 Date: Thu, 30 Jul 2015 15:51:24 -0700 (PDT) Message-Id: <20150730.155124.2216613161860898066.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vivien.didelot@savoirfairelinux.com, jerome.oufella@savoirfairelinux.com, linux@roeck-us.net, andrew@lunn.ch, cphealy@gmail.com, mathieu@codeaurora.org, jonasj76@gmail.com, andrey.volkov@nexvision.fr, Chris.Packham@alliedtelesis.co.nz Subject: Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion From: David Miller In-Reply-To: <20150730.141935.723435302404122784.davem@davemloft.net> References: <1438209160-6898-1-git-send-email-f.fainelli@gmail.com> <20150730.141935.723435302404122784.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Jul 2015 15:51:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6UMpZsW005023 From: David Miller Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > This looks fine, series applied, thanks. I think your control block is too large, you'll need to rework this somehow. In function ¡dsa_copy_brcm_tag¢, inlined from ¡bcm_sysport_desc_rx¢ at drivers/net/ethernet/broadcom/bcmsysport.c:707:4, inlined from ¡bcm_sysport_poll¢ at drivers/net/ethernet/broadcom/bcmsysport.c:864:12: include/linux/compiler.h:447:38: error: call to ¡__compiletime_assert_2016¢ declared with attribute error: BUILD_BUG_ON failed: sizeof(skb->cb) - sizeof(struct napi_gro_cb) < BRCM_TAG_LEN _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:430:4: note: in definition of macro ¡__compiletime_assert¢ prefix ## suffix(); \ ^ include/linux/compiler.h:447:2: note: in expansion of macro ¡_compiletime_assert¢ _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/bug.h:50:37: note: in expansion of macro ¡compiletime_assert¢ #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^ include/linux/bug.h:74:2: note: in expansion of macro ¡BUILD_BUG_ON_MSG¢ BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^ include/linux/netdevice.h:2016:2: note: in expansion of macro ¡BUILD_BUG_ON¢ BUILD_BUG_ON(sizeof(skb->cb) - sizeof(struct napi_gro_cb) < BRCM_TAG_LEN); ^ scripts/Makefile.build:264: recipe for target 'drivers/net/ethernet/broadcom/bcmsysport.o' failed ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayºʇڙë,j­¢f£¢·hšïêÿ‘êçz_è®(­éšŽŠÝ¢j"ú¶m§ÿÿ¾«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^¶m§ÿÿà ÿ¶ìÿ¢¸?–I¥