mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, eranian@google.com,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing
Date: Thu, 30 Jul 2015 15:42:34 +0200	[thread overview]
Message-ID: <20150730134234.GO9606@krava.brq.redhat.com> (raw)
In-Reply-To: <1438215700-5530-3-git-send-email-andi@firstfloor.org>

On Wed, Jul 29, 2015 at 05:21:38PM -0700, Andi Kleen wrote:

SNIP

> +static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg,
> +			  void *ctx, print_metric_t print_metric)
>  {
>  	double msecs = avg / 1e6;
>  	const char *fmt_v, *fmt_n;
> @@ -647,13 +689,16 @@ static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg)
>  		return;
>  
>  	if (perf_evsel__match(evsel, SOFTWARE, SW_TASK_CLOCK))
> -		fprintf(output, " # %8.3f CPUs utilized          ",
> -			avg / avg_stats(&walltime_nsecs_stats));
> +		print_metric(ctx, NULL, "%8.3f", "CPUs utilized",
> +			     avg / avg_stats(&walltime_nsecs_stats));
>  	else
> -		fprintf(output, "                                   ");
> +		print_metric(ctx, NULL, NULL, NULL, 0);
>  }

hum, this should go to perf_stat__print_shadow_stats,
could you please move it there before this patch?

thanks,
jirka

  reply	other threads:[~2015-07-30 13:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  0:21 perf, tools: Refactor and support interval and CSV metrics Andi Kleen
2015-07-30  0:21 ` [PATCH 1/4] perf, tools: Do not include escape sequences in color_vfprintf return Andi Kleen
2015-07-30 12:35   ` [PATCH] perf tools: Remove color_fprintf_ln function Jiri Olsa
2015-07-30  0:21 ` [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-07-30 13:42   ` Jiri Olsa [this message]
2015-07-30 13:47   ` Jiri Olsa
2015-08-04  0:41     ` Andi Kleen
2015-08-08 17:40       ` Jiri Olsa
2015-07-30  0:21 ` [PATCH 3/4] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-07-30 13:53   ` Jiri Olsa
2015-07-30  0:21 ` [PATCH 4/4] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-07-30 14:06   ` Jiri Olsa
2015-07-30 14:08   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730134234.GO9606@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome