From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbbG3OIw (ORCPT ); Thu, 30 Jul 2015 10:08:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40064 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbbG3OIv (ORCPT ); Thu, 30 Jul 2015 10:08:51 -0400 Date: Thu, 30 Jul 2015 16:08:48 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 4/4] perf, tools, stat: Implement CSV metrics output Message-ID: <20150730140848.GS9606@krava.brq.redhat.com> References: <1438215700-5530-1-git-send-email-andi@firstfloor.org> <1438215700-5530-5-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438215700-5530-5-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2015 at 05:21:40PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Now support CSV output for metrics. With the new output callbacks > this is relatively straight forward by creating new callbacks. > > The new line callback needs to know the number of fields to skip them > correctly > > To avoid reordering the existing CSV fields, I had to move > the noise printing into the lower level print metrics call back, > so that noise can be printed before metrics. > > This actually cleans up the callers because it avoids a lot > of duplicated code. nice, please separate the cleanup from the actual addition of the metrics CSV fields could you please also start some documentation in perf stat man? I dont think we have anything yet.. and it's getting bigger ;-) thanks, jirka