From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbbG3PCO (ORCPT ); Thu, 30 Jul 2015 11:02:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:40448 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbbG3PCN (ORCPT ); Thu, 30 Jul 2015 11:02:13 -0400 Date: Thu, 30 Jul 2015 17:02:09 +0200 From: Petr Mladek To: Tejun Heo Cc: akpm@linux-foundation.org, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] printk: Warn about dropped messages also on extended consoles Message-ID: <20150730150209.GM2673@pathway.suse.cz> References: <1438255732-31326-1-git-send-email-pmladek@suse.com> <20150730133901.GC3504@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730133901.GC3504@mtj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2015-07-30 09:39:01, Tejun Heo wrote: > Hello, > > On Thu, Jul 30, 2015 at 01:28:52PM +0200, Petr Mladek wrote: > > The commit #6fe29354befe4c ("printk: implement support for extended console > > drivers") added an extra buffer to format messages for extended consoles. > > We need to put there also the warning about dropped messages, so it appears > > on these consoles. > > I don't get it. Extended messages are all stamped with sequence > number and the gap in sequence number is a clear sign of missing > messages. Grr, I misconfigured netconsole and did not see the extended information. You are right, the patch is not needed. Best Regards, Petr