From: David Miller <davem@davemloft.net>
To: nathan.sullivan@ni.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume
Date: Fri, 31 Jul 2015 00:22:04 -0700 (PDT) [thread overview]
Message-ID: <20150731.002204.2044640569422262574.davem@davemloft.net> (raw)
In-Reply-To: <20150730230905.GA9355@nathan3500-linux-VM>
From: Nathan Sullivan <nathan.sullivan@ni.com>
Date: Thu, 30 Jul 2015 18:09:05 -0500
> On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote:
>> From: Nathan Sullivan <nathan.sullivan@ni.com>
>> Date: Thu, 30 Jul 2015 10:15:48 -0500
>>
>> > Changes for V2: Actually make sure it compiles this time.
>>
>> If V1 didn't compile, even for you, then I have a big problem.
>>
>> And that problem is that you didn't test this change at all.
>
> Sorry about that, I have tested it against 3.14, which is why I had
> the older interrupt function in v1. On HEAD, the phy no longer
> suspends when ethernet goes down on our hardware - I'm still working
> on figuring out why. I'm also surprised no one noticed this behavior
> before I did, but if the phy never goes into suspend you wouldn't.
I think you should sort out the PHY suspending issue before we move
forward with this patch.
next prev parent reply other threads:[~2015-07-31 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:15 Nathan Sullivan
2015-07-30 16:40 ` Florian Fainelli
2015-07-30 17:00 ` David Miller
2015-07-30 23:09 ` Nathan Sullivan
2015-07-31 7:22 ` David Miller [this message]
2015-07-31 14:27 ` Nathan Sullivan
2015-07-31 20:21 ` David Miller
2015-07-30 18:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731.002204.2044640569422262574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®