From: Dong Aisheng <aisheng.dong@freescale.com>
To: "Jan Lübbe" <jlu@pengutronix.de>
Cc: Haibo Chen <haibo.chen@freescale.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<shawnguo@kernel.org>, <kernel@pengutronix.de>,
<linux@arm.linux.org.uk>, <ulf.hansson@linaro.org>,
<fabio.estevam@freescale.com>, <devicetree@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<johan.derycke@barco.com>, <b29396@freescale.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support
Date: Fri, 31 Jul 2015 12:41:49 +0800 [thread overview]
Message-ID: <20150731044146.GA27806@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <1438273506.26075.2.camel@pengutronix.de>
On Thu, Jul 30, 2015 at 06:25:06PM +0200, Jan Lübbe wrote:
> On Mi, 2015-07-29 at 17:03 +0800, Haibo Chen wrote:
> > tuning-step is the delay cell steps in tuning procedure. The default
> > value of tuning-step is 1. For imx6 series usdhc, tuning procedure can
> > be passed when the tuning-step value is 1. But imx7d usdhc need the
> > tuning-step value as 2, otherwise it can't pass the tuning procedure.
> >
> > So this patch add the tuning-step setting in driver, so that user can
> > set the tuning-step value in dts.
>
> From your description, the correct tuning-step value only depends on the
> SoC. Why not derive it from the compatible string?
>
'tuning-step' actually depends on board and card.
The commit message should be reformed a bit.
Regards
Dong Aisheng
> Regards,
> Jan Lübbe
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
next prev parent reply other threads:[~2015-07-31 4:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 9:03 [PATCH v3 0/6] mmc: imx: a few fixes and new feature Haibo Chen
2015-07-29 9:03 ` [PATCH v3 1/6] mmc: sdhci-esdhc-imx: add imx7d support and support HS400 Haibo Chen
2015-07-31 14:15 ` Dong Aisheng
[not found] ` <BY1PR03MB13889195F33D0010E6759D309A880@BY1PR03MB1388.namprd03.prod.outlook.com>
2015-08-03 12:09 ` Dong Aisheng
[not found] ` <BY1PR03MB13888A2D2946E6B41EBFFFE19A750@BY1PR03MB1388.namprd03.prod.outlook.com>
2015-08-05 7:53 ` Dong Aisheng
2015-08-04 3:25 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support Haibo Chen
2015-07-30 16:25 ` Jan Lübbe
2015-07-31 4:41 ` Dong Aisheng [this message]
2015-07-29 9:03 ` [PATCH v3 3/6] ARM: dts: imx7d-sdb: add eMMC5.0 support Haibo Chen
2015-07-31 14:46 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 4/6] mmc: sdhci-esdhc-imx: add compatible string in bingding doc Haibo Chen
2015-07-31 14:43 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 5/6] mmc: sdhci-esdhc-imx: config watermark level and burst length Haibo Chen
2015-07-31 14:51 ` Dong Aisheng
2015-07-31 15:13 ` Russell King - ARM Linux
2015-08-03 10:14 ` Dong Aisheng
2015-07-31 14:55 ` Dong Aisheng
2015-07-29 9:03 ` [PATCH v3 6/6] mmc: sdhci-esdhc-imx: set back the burst_length_enable bit to 1 Haibo Chen
2015-07-31 14:57 ` Dong Aisheng
[not found] ` <BY1PR03MB138838EFB0DE8834DE5889669A770@BY1PR03MB1388.namprd03.prod.outlook.com>
2015-08-03 12:12 ` Dong Aisheng
2015-07-29 9:10 ` [PATCH v3 0/6] mmc: imx: a few fixes and new feature Dong Aisheng
2015-07-30 9:44 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731044146.GA27806@shlinux1.ap.freescale.net \
--to=aisheng.dong@freescale.com \
--cc=b29396@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=galak@codeaurora.org \
--cc=haibo.chen@freescale.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jlu@pengutronix.de \
--cc=johan.derycke@barco.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®