From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>,
<p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<linux@arm.linux.org.uk>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER
Date: Fri, 31 Jul 2015 09:47:07 -0700 [thread overview]
Message-ID: <20150731164707.GF2650@xsjsorenbubuntu> (raw)
In-Reply-To: <55BB2D39.6000004@xilinx.com>
On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote:
> On 07/31/2015 03:13 AM, Moritz Fischer wrote:
> > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> > ---
> > arch/arm/mach-zynq/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> > index 78e5e00..77d7df7 100644
> > --- a/arch/arm/mach-zynq/Kconfig
> > +++ b/arch/arm/mach-zynq/Kconfig
> > @@ -1,5 +1,6 @@
> > config ARCH_ZYNQ
> > bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> > + select ARCH_HAS_RESET_CONTROLLER
> > select ARCH_SUPPORTS_BIG_ENDIAN
> > select ARM_AMBA
> > select ARM_GIC
> >
>
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
I personally, would prefer to decouple the logical outputs of the
reset-controller from the HW. But, as Moritz pointed out, that seems
rather uncommon for reset controllers. I think this is good to go.
Thanks,
Sören
next prev parent reply other threads:[~2015-07-31 17:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 1:13 [RFCv3 0/4] Adding support for Zynq Reset Controller Moritz Fischer
2015-07-31 1:13 ` [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings Moritz Fischer
2015-08-04 8:09 ` Philipp Zabel
2015-08-04 8:18 ` Michal Simek
2015-08-04 15:05 ` Moritz Fischer
2015-08-04 15:10 ` Philipp Zabel
2015-08-05 19:43 ` Moritz Fischer
2015-08-06 4:54 ` Michal Simek
2015-07-31 1:13 ` [RFCv3 2/4] dts: zynq: Add devicetree entry for Xilinx Zynq reset controller Moritz Fischer
2015-08-04 8:13 ` Michal Simek
2015-07-31 1:13 ` [RFCv3 3/4] reset: reset-zynq: Adding support " Moritz Fischer
2015-07-31 1:13 ` [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER Moritz Fischer
2015-07-31 8:09 ` Michal Simek
2015-07-31 16:47 ` Sören Brinkmann [this message]
2015-08-04 8:38 ` Philipp Zabel
2015-08-04 14:11 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731164707.GF2650@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=moritz.fischer@ettus.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®