mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: green@linuxhacker.ru
Cc: devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/13] staging/lustre: Drop SEEK_* definition checks
Date: Fri, 31 Jul 2015 16:00:53 -0700	[thread overview]
Message-ID: <20150731230053.GA22744@kroah.com> (raw)
In-Reply-To: <1438295284-2307773-7-git-send-email-green@linuxhacker.ru>

On Thu, Jul 30, 2015 at 06:27:57PM -0400, green@linuxhacker.ru wrote:
> From: Oleg Drokin <green@linuxhacker.ru>
> 
> SEEK_DATA and SEEK_HOLE are always defined in the kernel,
> drop the definition checks
> 
> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
> ---
>  .../lustre/lustre/include/linux/lustre_compat25.h  | 38 ----------------------
>  1 file changed, 38 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> index d0e8f3c..7d90999 100644
> --- a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> +++ b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> @@ -69,37 +69,6 @@
>  # define inode_dio_read(i)		atomic_inc(&(i)->i_dio_count)
>  /* inode_dio_done(i) use as-is for read unlock */
>  
> -static inline int
> -ll_quota_on(struct super_block *sb, int off, int ver, char *name, int remount)
> -{
> -	int rc;
> -
> -	if (sb->s_qcop->quota_on) {
> -		struct path path;
> -
> -		rc = kern_path(name, LOOKUP_FOLLOW, &path);
> -		if (!rc)
> -			return rc;
> -		rc = sb->s_qcop->quota_on(sb, off, ver
> -					    , &path
> -					   );
> -		path_put(&path);
> -		return rc;
> -	} else
> -		return -ENOSYS;
> -}
> -
> -static inline int ll_quota_off(struct super_block *sb, int off, int remount)
> -{
> -	if (sb->s_qcop->quota_off) {
> -		return sb->s_qcop->quota_off(sb, off
> -					    );
> -	} else
> -		return -ENOSYS;
> -}
> -
> -
> -

This code removal doesn't match up with the changelog text, so I can't
take this :(


  reply	other threads:[~2015-07-31 23:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 22:27 [PATCH 00/13] Removal of lustre compat macros green
2015-07-30 22:27 ` [PATCH 01/13] staging/lustre: Remove unused ll_vfs_* compat defines green
2015-07-30 22:27 ` [PATCH 02/13] staging/lustre: get rid of cfs_bio_* compat macroses green
2015-07-30 22:27 ` [PATCH 03/13] staging/lustre: Drop FS_HAS_FIEMAP compat macro green
2015-07-30 22:27 ` [PATCH 04/13] staging/lustre: Drop SLAB_DESTROY_BY_RCU redefine, it's always defined green
2015-07-30 22:27 ` [PATCH 05/13] staging/lustre: remove *hw_segments compat defines green
2015-07-30 22:27 ` [PATCH 06/13] staging/lustre: Drop SEEK_* definition checks green
2015-07-31 23:00   ` Greg Kroah-Hartman [this message]
2015-07-31 23:37     ` Oleg Drokin
2015-07-30 22:27 ` [PATCH 07/13] staging/lustre: Drop FMODE_UNSIGNED_OFFSET define green
2015-07-30 22:27 ` [PATCH 08/13] staging/lustre: replace ll_umode_t with umode_t green
2015-07-30 22:28 ` [PATCH 09/13] staging/lustre: Use hlist primitives directly green
2015-07-30 22:28 ` [PATCH 10/13] staging/lustre: Get rid of ll_pagevec_ macros green
2015-07-30 22:28 ` [PATCH 11/13] staging/lustre: ATTR_TIMES_SET is always defined, so don't check it green
2015-07-30 22:28 ` [PATCH 12/13] staging/lustre: Get rid of inode_dio_write_done and inode_dio_read green
2015-07-30 22:28 ` [PATCH 13/13] staging/lustre: use ATTR_OPEN directly, remove ATTR_RAW green
2015-07-31 23:03 ` [PATCH 00/13] Removal of lustre compat macros Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731230053.GA22744@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=green@linuxhacker.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome