From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbbHAK7g (ORCPT ); Sat, 1 Aug 2015 06:59:36 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49542 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbbHAK7e (ORCPT ); Sat, 1 Aug 2015 06:59:34 -0400 Date: Sat, 1 Aug 2015 11:59:14 +0100 From: Mark Brown To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Message-ID: <20150801105914.GR20873@sirena.org.uk> References: <1438371747-8644-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="soWJpSPh+l8Y6Fy7" Content-Disposition: inline In-Reply-To: <1438371747-8644-1-git-send-email-yamada.masahiro@socionext.com> X-Cookie: Please take note: User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.197.121.99 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: remove redundant $(CONFIG_REGMAP) in Makefile X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --soWJpSPh+l8Y6Fy7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 01, 2015 at 04:42:27AM +0900, Masahiro Yamada wrote: > Kbuild descends into drivers/base/regmap/ only when CONFIG_REGMAP > is enabled. (see drivers/base/Makefile) >=20 > $(CONFIG_REGMAP) in drivers/base/regmap/Makefile always evaluates > to 'y'. > -obj-$(CONFIG_REGMAP) +=3D regmap.o regcache.o > -obj-$(CONFIG_REGMAP) +=3D regcache-rbtree.o regcache-lzo.o regcache-flat= =2Eo > +obj-y +=3D regmap.o regcache.o > +obj-y +=3D regcache-rbtree.o regcache-lzo.o regcache-flat.o > obj-$(CONFIG_DEBUG_FS) +=3D regmap-debugfs.o > obj-$(CONFIG_REGMAP_AC97) +=3D regmap-ac97.o > obj-$(CONFIG_REGMAP_I2C) +=3D regmap-i2c.o OTOH it does make the Makefile look a bit neater to have everything selected by config option... is there a practical cost here? --soWJpSPh+l8Y6Fy7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVvKaBAAoJECTWi3JdVIfQMrQH+wVf+FWn8cOj8O1qKfIc8A46 AklyAAPCxZAL19/8NhgaU1cpbf+PuEMondR8T3SPld0mNywoaLyxJxzzAM0ucnI5 3//gVWdsCkdvD3YagkVyVHKGSudhVWkq5XYvzI332Wz1nx9LM/pa4Gj4KLfziirp 0UkOOIHBdlvCtgLmXdBJKbGodPfL+G/uo6hLX/MiZ+ULR7ASW/TrSQdAGWVapAqt awba+4n3UFTSNrobTEIwpBiZWMQuUP8AamEeHICWYZu+uPANgllp9ETOQYf3NRja In9MlXza3dhVDHjtIhF1giDNbPX6S/L75lsygn833SXOmVovC5+0h0DtV/3PBG0= =2N6Z -----END PGP SIGNATURE----- --soWJpSPh+l8Y6Fy7--