From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755558AbbHCVDf (ORCPT ); Mon, 3 Aug 2015 17:03:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44817 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754295AbbHCVDe (ORCPT ); Mon, 3 Aug 2015 17:03:34 -0400 Date: Mon, 03 Aug 2015 14:03:28 -0700 (PDT) Message-Id: <20150803.140328.574050334230752525.davem@davemloft.net> To: ggriffin.kernel@gmail.com Cc: pshelar@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments From: David Miller In-Reply-To: <20150803165654.GA16892@google.com> References: <20150803165654.GA16892@google.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2015 14:03:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Glenn Griffin Date: Mon, 3 Aug 2015 09:56:54 -0700 > openvswitch modifies the L4 checksum of a packet when modifying > the ip address. When an IP packet is fragmented only the first > fragment contains an L4 header and checksum. Prior to this change > openvswitch would modify all fragments, modifying application data > in non-first fragments, causing checksum failures in the > reassembled packet. > > Signed-off-by: Glenn Griffin > --- > Changes in v2: > - Compare frag_off in network byte order rather than host byte order Applied and queued up for -stable.