From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751654AbbHDE7D (ORCPT ); Tue, 4 Aug 2015 00:59:03 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47107 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbHDE7B (ORCPT ); Tue, 4 Aug 2015 00:59:01 -0400 Date: Mon, 03 Aug 2015 21:59:00 -0700 (PDT) Message-Id: <20150803.215900.915316341182067498.davem@davemloft.net> To: joe@perches.com Cc: Jason@zx2c4.com, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG From: David Miller In-Reply-To: <1438660941.10829.3.camel@perches.com> References: <1438658773-3220-1-git-send-email-Jason@zx2c4.com> <1438660677.10829.1.camel@perches.com> <1438660941.10829.3.camel@perches.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2015 21:59:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Mon, 03 Aug 2015 21:02:21 -0700 > On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote: >> On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote: >> > This patch replaces calls to net_dbg_ratelimited when !DEBUG with >> > no_printk, keeping with the idiom of all the other debug print helpers. >> >> Makes sense, thanks Jason. > > Perhaps better still would be to use if (0) no_printk so that > the call and whatever argument calls the net_dbg_ratelimited > makes are completely eliminated. Agreed. Jason please respin your patch to work this way.