From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbbHCLX6 (ORCPT ); Mon, 3 Aug 2015 07:23:58 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:64515 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbbHCLX5 convert rfc822-to-8bit (ORCPT ); Mon, 3 Aug 2015 07:23:57 -0400 Date: Mon, 3 Aug 2015 12:23:53 +0100 From: Liviu Dudau To: Sudeep Holla Cc: "arm@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Olof Johansson , Kevin Hilman , Punit Agrawal , "Jon Medhurst (Tixy)" , Lorenzo Pieralisi , Arnd Bergmann Subject: Re: [PATCH v6 6/8] arm64: dts: add SRAM, MHU mailbox and SCPI support on Juno Message-ID: <20150803112353.GV20890@e106497-lin.cambridge.arm.com> References: <1438364591-1144-1-git-send-email-sudeep.holla@arm.com> <1438364591-1144-7-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 In-Reply-To: <1438364591-1144-7-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 03 Aug 2015 11:23:53.0906 (UTC) FILETIME=[E13D2920:01D0CDDE] X-MC-Unique: WkBIkRmKQ0Ozb6QRXc4pCA-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2015 at 06:43:09PM +0100, Sudeep Holla wrote: > This patch adds support for the MHU mailbox peripheral used on Juno by > application processors to communicate with remote SCP handling most of > the CPU/system power management. It also adds the SRAM reserving the > shared memory and SCPI message protocol using that shared memory. > > Signed-off-by: Sudeep Holla > Acked-by: Liviu Dudau > Cc: Jon Medhurst (Tixy) > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 54 ++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index e3ee96036eca..c624208edef6 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -17,6 +17,18 @@ > }; > }; > > + mailbox: mhu@2b1f0000 { > + compatible = "arm,mhu", "arm,primecell"; > + reg = <0x0 0x2b1f0000 0x0 0x1000>; > + interrupts = , > + ; > + interrupt-names = "mhu_lpri_rx", > + "mhu_hpri_rx"; > + #mbox-cells = <1>; > + clocks = <&soc_refclk100mhz>; > + clock-names = "apb_pclk"; > + }; > + > gic: interrupt-controller@2c010000 { > compatible = "arm,gic-400", "arm,cortex-a15-gic"; > reg = <0x0 0x2c010000 0 0x1000>, > @@ -44,6 +56,48 @@ > ; > }; > > + sram: sram@2e000000 { > + compatible = "arm,juno-sram-ns", "mmio-sram"; > + reg = <0x0 0x2e000000 0x0 0x8000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x2e000000 0x8000>; > + > + cpu_scp_lpri: scp-shmem@0 { > + compatible = "arm,juno-scp-shmem"; > + reg = <0x0 0x200>; > + }; > + > + cpu_scp_hpri: scp-shmem@200 { > + compatible = "arm,juno-scp-shmem"; > + reg = <0x200 0x200>; > + }; > + }; > + > + scpi { > + compatible = "arm,scpi"; > + mboxes = <&mailbox 1>; > + shmem = <&cpu_scp_hpri>; > + > + clocks { > + compatible = "arm,scpi-clocks"; > + > + scpi_dvfs: scpi_clocks@0 { > + compatible = "arm,scpi-dvfs-clocks"; > + #clock-cells = <1>; > + clock-indices = <0>, <1>, <2>; > + clock-output-names = "atlclk", "aplclk","gpuclk"; > + }; > + scpi_clk: scpi_clocks@3 { > + compatible = "arm,scpi-variable-clocks"; > + #clock-cells = <1>; > + clock-indices = <3>, <4>; > + clock-output-names = "pxlclk0", "pxlclk1"; > + }; > + }; > + }; > + Sorry for noticing this after the ACK, is there any reason why the scpi node is not inside the juno-clocks.dtsi file? Best regards, Liviu > /include/ "juno-clocks.dtsi" > > dma@7ff00000 { > -- > 1.9.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯