From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753751AbbHCNK3 (ORCPT ); Mon, 3 Aug 2015 09:10:29 -0400 Received: from relay2.sgi.com ([192.48.180.65]:51657 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752178AbbHCNK1 (ORCPT ); Mon, 3 Aug 2015 09:10:27 -0400 Date: Mon, 3 Aug 2015 08:10:20 -0500 From: Dimitri Sivanich To: Joe Perches Cc: linux-kernel@vger.kernel.org Subject: Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x Message-ID: <20150803131020.GA26870@sgi.com> References: <1438547247.29569.7.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438547247.29569.7.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This should be %d, not 0x%x. Nacked-by: Dimitri Sivanich On Sun, Aug 02, 2015 at 01:27:27PM -0700, Joe Perches wrote: > Correct misuse of 0x%d in logging message. > > Signed-off-by: Joe Perches > --- > drivers/misc/sgi-gru/grumain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c > index ae16c8c..a1ce324 100644 > --- a/drivers/misc/sgi-gru/grumain.c > +++ b/drivers/misc/sgi-gru/grumain.c > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru, > spin_lock(&gru->gs_asid_lock); > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); > asids->mt_ctxbitmap ^= ctxbitmap; > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n", > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n", > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]); > spin_unlock(&gru->gs_asid_lock); > spin_unlock(&gms->ms_asid_lock);