From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbbHCRfc (ORCPT ); Mon, 3 Aug 2015 13:35:32 -0400 Received: from smtprelay0038.hostedemail.com ([216.40.44.38]:42622 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754604AbbHCRfb (ORCPT ); Mon, 3 Aug 2015 13:35:31 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3872:4321:5007:6261:7514:7829:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: dress88_2ff51a31bcc22 X-Filterd-Recvd-Size: 1912 Date: Mon, 3 Aug 2015 13:35:28 -0400 From: Steven Rostedt To: yangoliver Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Yong Yang , Peter Zijlstra Subject: Re: [PATCH 2/2] sched: Trace point sched_stat_sleep should cover iowait case Message-ID: <20150803133528.11d77554@gandalf.local.home> In-Reply-To: References: <1438002714-8158-1-git-send-email-yangoliver@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Adding Peter Zijlstra to this ] -- Steve On Mon, 27 Jul 2015 09:11:52 -0400 yangoliver wrote: > Per sched_stat_sleep definition in sched.h, it should include > iowait case. This can also relect the design of sum_sleep_runtime > statistic, as this counter also includes the io_wait. > > Signed-off-by: Yong Yang > --- > kernel/sched/fair.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d113c3b..85677bf 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3018,6 +3018,8 @@ static void enqueue_sleeper(struct cfs_rq *cfs_rq, struct sched_entity *se) > se->statistics.sum_sleep_runtime += delta; > > if (tsk) { > + trace_sched_stat_sleep(tsk, delta); > + > if (tsk->in_iowait) { > se->statistics.iowait_sum += delta; > se->statistics.iowait_count++;