From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933104AbbHDKrb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 Aug 2015 06:47:31 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:48147 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932437AbbHDKr3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 Aug 2015 06:47:29 -0400
Date: Tue, 4 Aug 2015 12:47:23 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andrey Konovalov <andreyknvl@google.com>, Ingo Molnar <mingo@kernel.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic
Message-ID: <20150804104723.GP25159@twins.programming.kicks-ass.net>
References: <1438674948-38310-1-git-send-email-borntraeger@de.ibm.com>
 <1438674948-38310-2-git-send-email-borntraeger@de.ibm.com>
 <20150804092027.GN25159@twins.programming.kicks-ass.net>
 <55C094E0.7020406@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55C094E0.7020406@de.ibm.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 04, 2015 at 12:33:04PM +0200, Christian Borntraeger wrote:
> Am 04.08.2015 um 11:20 schrieb Peter Zijlstra:
> > On Tue, Aug 04, 2015 at 09:55:48AM +0200, Christian Borntraeger wrote:
> >> kernel build bot showed a warning triggered by commit
> >> 76695af20c01 ("locking, arch: use WRITE_ONCE()/READ_ONCE() in
> >> smp_store_release()/smp_load_acquire()"). Turns out that sparse
> >> does not like WRITE_ONCE accessing elements from the (sparse)
> >> rcu address space.
> >>
> >> fs/afs/inode.c:448:9: sparse: incorrect type in initializer (different address spaces)
> >> fs/afs/inode.c:448:9:    expected struct afs_permits *__val
> >> fs/afs/inode.c:448:9:    got void [noderef] <asn:4>*<noident>
> >>
> >> Solution is to force cast away the sparse attributes for the initializer
> >> of the union in WRITE_SAME. As this now gets too long, lets split
> > 
> > WRITE_ONCE, right?
> 
> Indeed, guess what area I was looking into before....;-)
> 
> Shall I respin or can you fixup.

I've already fixed it. Thanks!